Horton

Re: Is it useful to record whether plans are generic or custom?

Chengxi Sun <sunchengxi@highgo.com>

View thread View on postgr.es
From: Chengxi Sun <sunchengxi@highgo.com>
To: pgsql-hackers@lists.postgresql.org
Cc: Atsushi Torikoshi <torikoshia@oss.nttdata.com>
Date: 2021-01-22T11:25:40Z
Lists: pgsql-hackers 
The following review has been posted through the commitfest application:
make installcheck-world:  tested, failed
Implements feature:       tested, failed
Spec compliant:           not tested
Documentation:            not tested

Hi Atsushi,

I just run a few test on your latest patch. It works well. I agree with you, I think just tracking generic_calls is enough to get the reason of performance change from pg_stat_statements. I mean if you need more detailed information about the plan and execution of prepared statements, it is better to store this information in a separate view. It seems more reasonable to me.

Regards,

Commits

  1. Add generic_plans and custom_plans fields into pg_prepared_statements.