Re: make installcheck-world in a clean environment
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Alexander Lakhin <exclusion@gmail.com>
Cc: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>,
Robert Haas <robertmhaas@gmail.com>,
"pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Date: 2018-07-11T20:15:41Z
Lists: pgsql-hackers
Alexander Lakhin <exclusion@gmail.com> writes: > 06.07.2018 00:39, Peter Eisentraut wrote: >> Exactly what order of steps are you executing that doesn't work? > In Centos 7, using the master branch from git: > ./configure --enable-tap-tests > make install > make install -C contrib > chown -R postgres:postgres /usr/local/pgsql/ > /usr/local/pgsql/bin/initdb -D /usr/local/pgsql/data > /usr/local/pgsql/bin/pg_ctl start -l logfile -D /usr/local/pgsql/data > /make clean/ > # Also you can just install binary packages to get the same state. > make installcheck-world > # This check fails. I do not think that should be expected to work. It would require that "make installcheck" first invoke "make all" (to rebuild the stuff you threw away with "make clean"), which is rather antithetical to its purpose. Specifically, installcheck is supposed to be checking something you already built; so having it do a fresh build seems to introduce version-skew hazards that we don't need. regards, tom lane
Commits
-
Ensure we build generated headers at the start of some more cases.
- 7dc5a96aa218 12.0 landed
- 739d9b29948b 11.0 landed