Horton

Re: [PATCH] (Windows) psql echoes password when reading from pipe

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Matthew Stickney <mtstickney@gmail.com>
Cc: pgsql-hackers@lists.postgresql.org
Date: 2018-05-23T23:06:29Z
Lists: pgsql-hackers 
Matthew Stickney <mtstickney@gmail.com> writes:
> The attached is a patch that uses the _fileno/_get_osfhandle approach. 
> This doesn't address the stdin fallback, or error handling if opening 
> termin fails; however, it should be no worse than what's there now, and 
> it fixes the immediate problem.

LGTM; pushed with some cosmetic changes.

> I'm still thinking about the fallback in terms of a mintty-type 
> environment, but I wanted to get this patch out there in the meantime.

Yeah.  I'm not absolutely sure that we need to do anything there,
given the lack of field complaints; but if we can think of a simple
way to make it more bulletproof, all the better.

			regards, tom lane

Commits

  1. Fix simple_prompt() to disable echo on Windows when stdin != terminal.