Horton

Re: pg_rewind copies

Cary Huang <cary.huang@highgo.ca>

View thread View on postgr.es
From: Cary Huang <cary.huang@highgo.ca>
To: pgsql-hackers@lists.postgresql.org
Cc: Heikki Linnakangas <hlinnaka@iki.fi>
Date: 2020-12-15T22:08:50Z
Lists: pgsql-hackers 
The following review has been posted through the commitfest application:
make installcheck-world:  tested, passed
Implements feature:       tested, passed
Spec compliant:           tested, passed
Documentation:            not tested

Hello

The patch seems to do as described and the regression and tap tests are passing 
+	/*
+	 * A local source is not expected to change while we're rewinding, so check
+	 * that we size of the file matches our earlier expectation.
+	 */
Is this a tyoo?

thanks
Cary

Commits

  1. pg_rewind: Fetch small files according to new size.