Horton

Re: {CREATE INDEX, REINDEX} CONCURRENTLY improvements

Hamid Akhtar <hamid.akhtar@gmail.com>

View thread View on postgr.es
From: Hamid Akhtar <hamid.akhtar@gmail.com>
To: pgsql-hackers@lists.postgresql.org
Cc: Álvaro Herrera <alvherre@alvh.no-ip.org>
Date: 2020-12-08T08:17:25Z
Lists: pgsql-hackers 
The following review has been posted through the commitfest application:
make installcheck-world:  tested, passed
Implements feature:       not tested
Spec compliant:           not tested
Documentation:            not tested

The patch looks good to me. With regards to the code comments, I had pretty similar concerns as already raised by Dmitry; and those have already been answered by you. So this patch is good to go from my side once you have updated the comments per your last email.

Commits

  1. VACUUM: ignore indexing operations with CONCURRENTLY

  2. Avoid spurious wait in concurrent reindex

  3. Invent struct ReindexIndexInfo