Re: Requiring recovery.signal or standby.signal when recovering with a backup_label

Bowen Shi <zxwsbg12138@gmail.com>

From: Bowen Shi <zxwsbg12138@gmail.com>

To: pgsql-hackers@lists.postgresql.org

Cc: Michael Paquier <michael@paquier.xyz>

Date: 2023-10-16T06:21:07Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Delay recovery mode LOG after reading backup_label and/or checkpoint record
- dc5bd3889437 17.0 landed
Mention standby.signal in FATALs for checkpoint record missing at recovery
- 1ffdc03c21ae 17.0 landed
XLOG file archiving and point-in-time recovery. There are still some
- 66ec2db72840 8.0.0 cited

The following review has been posted through the commitfest application:
make installcheck-world:  tested, passed
Implements feature:       tested, passed
Spec compliant:           tested, passed
Documentation:            tested, passed

It looks good to me.

I have reviewed the code and tested the patch with basic check-world test an pgbench test (metioned in https://www.postgresql.org/message-id/flat/ZQtzcH2lvo8leXEr%40paquier.xyz#cc5ed83e0edc0b9a1c1305f08ff7a335). 

Another reviewer has also approved it, so I change the status to RFC.

The new status of this patch is: Ready for Committer