Horton

Re: [HACKERS] pg_serial early wraparound

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Thomas Munro <thomas.munro@enterprisedb.com>
Cc: Anastasia Lubennikova <lubennikovaav@gmail.com>, Pg Hackers <pgsql-hackers@postgresql.org>
Date: 2018-03-30T19:14:22Z
Lists: pgsql-hackers 
Thomas Munro <thomas.munro@enterprisedb.com> writes:
> On Tue, Mar 27, 2018 at 5:50 AM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> I'm a little worried because Anastasia couldn't repeat the test;
>> why is that?

> Hmm.  I'm not sure.  It works for me on a couple of machines and what I see is:

Yeah, it works for me too, so not sure what the problem was.

The only other point I can think of is that by changing the storage
layout under pg_serial/, this'd create an issue for pg_upgrade, if
pg_upgrade tried to migrate this data.  But it doesn't.

Hence, pushed.

			regards, tom lane

Commits

  1. Remove obsolete SLRU wrapping and warnings from predicate.c.

  2. Remove incorrect assertion in clog.c

  3. Keep track of transaction commit timestamps

  4. Handle 5-char filenames in SlruScanDirectory