Horton
Menu

Re: Fwd: Re: A new look at old NFS readdir() problems?

Tom Lane <tgl@sss.pgh.pa.us>

View thread
From: Tom Lane <tgl@sss.pgh.pa.us>
To: David Steele <david@pgbackrest.org>
Cc: Bruce Momjian <bruce@momjian.us>, Thomas Munro <thomas.munro@gmail.com>, Greg Sabino Mullane <htamfids@gmail.com>, Robert Haas <robertmhaas@gmail.com>, Larry Rosenman <ler@lerctr.org>, Pgsql hackers <pgsql-hackers@lists.postgresql.org>
Date: 2025-01-08T20:41:45Z
Lists: pgsql-hackers 
David Steele <david@pgbackrest.org> writes:
> On 1/8/25 12:40, Bruce Momjian wrote:
>> Will people now always get a clear error on failure?  

> The error will be something like "directory is not empty" when trying to 
> drop a database. So not very clear at all.

Conceivably we could adjust rmtree() to print a HINT mentioning that
unsafe network storage is a possible cause of this error.  But I'm
a little worried that that'd be crying wolf, because on most setups
a much more likely explanation is somebody concurrently creating a
file in the targeted directory.

			regards, tom lane