Horton

Re: 011_crash_recovery.pl intermittently fails

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Thomas Munro <thomas.munro@gmail.com>
Cc: Kyotaro Horiguchi <horikyota.ntt@gmail.com>, Peter Geoghegan <pg@bowt.ie>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, Craig Ringer <craig.ringer@enterprisedb.com>, Robert Haas <robertmhaas@gmail.com>
Date: 2021-03-08T01:09:33Z
Lists: pgsql-hackers 
Thomas Munro <thomas.munro@gmail.com> writes:
> Thanks!  I'm afraid I wouldn't get around to it for a few weeks, so if
> you have time, please do.  (I'm not sure if it's strictly necessary to
> log *this* xid, if a higher xid has already been logged, considering
> that the goal is just to avoid getting confused about an xid that is
> recycled after crash recovery, but coordinating that might be more
> complicated; I don't know.)

Yeah, ideally the patch wouldn't add any unnecessary WAL flush,
if there's some cheap way to determine that our XID must already
have been written out.  But I'm not sure that it's worth adding
any great amount of complexity to avoid that.  For sure I would
not advocate adding any new bookkeeping overhead in the mainline
code paths to support it.

			regards, tom lane

Commits

  1. Remove recovery test 011_crash_recovery.pl

  2. Add a txid_status function.