Re: C++ keywords in headers (was Re: [GENERAL] #include <funcapi.h>)

Tom Lane <tgl@sss.pgh.pa.us>

From: Tom Lane <tgl@sss.pgh.pa.us>
To: Peter Eisentraut <peter_e@gmx.net>
Cc: Craig Ringer <craig@postnewspapers.com.au>, Elliot Chance <elliotchance@gmail.com>, pgsql-hackers@postgresql.org
Date: 2010-12-27T16:54:56Z
Lists: pgsql-hackers
Peter Eisentraut <peter_e@gmx.net> writes:
> src/tools/pginclude/cpluspluscheck

Ah, I'd forgotten that.

> What's missing is to automate this, but it's unclear in what context,
> and perhaps also to what extend this should be a hard requirement.

After a bit of experimentation, I can say that this is better than
Andrew's hack, but it's still a good distance shy of something that
should be automated or treated as a hard requirement.  The problem with
it is that it doesn't know anything about inclusion-order restrictions;
and to make matters worse, the actual order in which things are included
will vary for different users, because of the unspecified order in which
'find' will find things.

[ lightbulb ] ... although we could improve that quite a bit if we
processed each .h file separately instead of insisting on smashing
everything into one compilation.  Let me go try that.

			regards, tom lane