Re: pg_waldump: add test for coverage
Tristen Raab <tristen.raab@highgo.ca>
From: Tristen Raab <tristen.raab@highgo.ca>
To: pgsql-hackers@lists.postgresql.org
Cc: Peter Eisentraut <peter@eisentraut.org>
Date: 2023-06-29T19:16:52Z
Lists: pgsql-hackers
The following review has been posted through the commitfest application: make installcheck-world: tested, passed Implements feature: tested, passed Spec compliant: not tested Documentation: not tested Hello, I've reviewed your latest v3 patches on Ubuntu 23.04. Both patches apply correctly and all the tests run and pass as they should. Execution time was normal for me, I didn't notice any significant latency when compared to other tests. The only other feedback I can provide would be to add test coverage to some of the other options that aren't currently covered (ie. --bkp-details, --end, --follow, --path, etc.) for completeness. Other than that, this looks like a great patch. Kind regards, Tristen
Commits
-
pg_waldump: Add test case for notice message
- 088539015173 17.0 landed
-
pg_waldump: Add more tests
- 96063e28366b 17.0 landed