Re: Fix misuse use of window_gettupleslot function (src/backend/executor/nodeWindowAgg.c)
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Ranier Vilela <ranier.vf@gmail.com>
Cc: Pg Hackers <pgsql-hackers@postgresql.org>
Date: 2025-10-05T16:05:01Z
Lists: pgsql-hackers
Ranier Vilela <ranier.vf@gmail.com> writes: > Per Coverity. > CID 1635309: (#1 of 1): Unchecked return value (CHECKED_RETURN) > 7. check_return: Calling window_gettupleslot without checking return value > (as is done elsewhere 8 out of 9 times). Yeah, the security team's Coverity instance just whined about that too. But isn't the correct behavior simply "return -1"? It looks to me like a failure should be interpreted as "row doesn't exist, therefore it's not in frame". What would be really useful is a test case that reaches this condition. That would make it plain what to do. regards, tom lane