Re: Add RISC-V Zbb popcount optimization

Tom Lane <tgl@sss.pgh.pa.us>

From: Tom Lane <tgl@sss.pgh.pa.us>
To: "Greg Burd" <greg@burd.me>
Cc: "Andres Freund" <andres@anarazel.de>, "Nathan Bossart" <nathandbossart@gmail.com>, "John Naylor" <johncnaylorls@gmail.com>, pgsql-hackers <pgsql-hackers@postgresql.org>, "Andrew Dunstan" <andrew@dunslane.net>
Date: 2026-05-29T16:23:11Z
Lists: pgsql-hackers
"Greg Burd" <greg@burd.me> writes:
> The zic.c hit is the one that bothers me.  It's the same shape as des_init() --
> byte-sized destination, scatter store via an indexing array -- and it's not
> exercised by `make check`, since zic runs at `make install` to compile the IANA
> tz data.

"make check" certainly *will* run zic.c, while creating the temporary
installation.  (Unless you use --with-system-tzdata, which I'm sure
most production builds do.)  But our test suite touches only a very
tiny fraction of the tzdata files, so even if there's some
corruption in them we wouldn't necessarily notice it.

			regards, tom lane