Re: Small PATCH: check of 2 Perl modules
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Teodor Sigaev <teodor@sigaev.ru>
Cc: Peter Eisentraut <peter_e@gmx.net>,
Eugene Kazakov <e.kazakov@postgrespro.ru>,
pgsql-hackers@postgresql.org
Date: 2016-02-15T15:02:12Z
Lists: pgsql-hackers
Teodor Sigaev <teodor@sigaev.ru> writes: >> On 2/12/16 8:20 AM, Eugene Kazakov wrote: >>> TAP-tests need two Perl modules: Test::More and IPC::Run. >> I think those modules are part of a standard Perl installation. > IPC::Run is not. At least for perl from ports tree in FreeBSD. Yeah, I remember having had to install IPC::Run from CPAN, and a couple of other things too (but I don't remember Test::More specifically), when setting up some of my buildfarm critters. It's likely that a lot of distros bundle these, but I don't think IPC::Run is in a basic built-from-source Perl. The real question though is do we need a configure check at all. Given that investigation into a CMake conversion is actively going on, I'm hesitant to move the goalposts for it by introducing a brand new type of configure check. Maybe we should punt this issue until that patch is either accepted or decisively rejected. regards, tom lane
Commits
-
Make configure check for IPC::Run when --enable-tap-tests is specified.
- c254970ad609 10.0 landed