Protection lost in expression eval changeover
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
Cc: pgsql-hackers@postgreSQL.org
Date: 2017-03-28T17:52:50Z
Lists: pgsql-hackers
CheckVarSlotCompatibility contains the comment * Note: we allow a reference to a dropped attribute. slot_getattr will * force a NULL result in such cases. While still true, that second sentence is now quite irrelevant, because we don't go through slot_getattr anymore. So it seems like we are missing some needed protection. I'm inclined to think that it'd be all right to just throw an error immediately in CheckVarSlotCompatibility if the target column is dropped. regards, tom lane
Commits
-
Make new expression eval code reject references to dropped columns.
- 2c4debbd0f01 10.0 landed