Horton

Re: BUG #15080: ecpg on windows doesn't define HAVE_LONG_LONG_INT

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andrew Gierth <andrew@tao11.riddles.org.uk>
Cc: Michael Meskes <meskes@postgresql.org>, jallen@americansavingslife.com, pgsql-bugs@lists.postgresql.org
Date: 2018-02-24T19:21:23Z
Lists: pgsql-bugs 
Andrew Gierth <andrew@tao11.riddles.org.uk> writes:
> Solution.pm has this:

> #if (_MSC_VER > 1200)
> #define HAVE_LONG_LONG_INT_64 1
> #define ENABLE_THREAD_SAFETY 1
> #endif

> from which HAVE_LONG_LONG_INT seems to be suspiciously missing?

I remember noticing that discrepancy recently when I was chasing something
else about int64 support.  It certainly looks wrong, but not being much of
an ecpg user I was hesitant to touch it.

			regards, tom lane

Commits

  1. Remove configure's check for nonstandard "long long" printf modifiers.

  2. printf("%lf") is not portable, so omit the "l".

  3. Support platforms where strtoll/strtoull are spelled __strtoll/__strtoull.

  4. Arrange to supply declarations for strtoll/strtoull if needed.

  5. Hot-fix ecpg regression test for missing ecpg_config.h inclusion.

  6. Add some test coverage for ecpg's "long long" support.

  7. Recognize that MSVC can support strtoll() and strtoull().

  8. Fix up ecpg's configuration so it handles "long long int" in MSVC builds.