Horton
Menu

Re: Ability to reference other extensions by schema in extension scripts

Sandro Santilli <strk@kbt.io>

View thread
From: Sandro Santilli <strk@kbt.io>
To: pgsql-hackers@lists.postgresql.org
Cc: Regina Obe <r@pcorp.us>
Date: 2023-02-28T23:43:13Z
Lists: pgsql-hackers 
The following review has been posted through the commitfest application:
make installcheck-world:  tested, failed
Implements feature:       tested, passed
Spec compliant:           tested, passed
Documentation:            tested, passed

I've applied the patch attached to message https://www.postgresql.org/message-id/000401d94bc8%2448dff700%24da9fe500%24%40pcorp.us (md5sum a7d45a32c054919d94cd4a26d7d07c20) onto current tip of the master branch being 128dd9f9eca0b633b51ffcd5b0f798fbc48ec4c0

The review written in https://www.postgresql.org/message-id/20230228224608.ak7br5shev4wic5a%40c19 all still applies.

The `make installcheck-world`  test fails for me but the failures seem unrelated to the patch (many occurrences of "+ERROR:  function pg_input_error_info(unknown, unknown) does not exist" in the regression.diff).

Documentation exists for the new feature

The new status of this patch is: Ready for Committer

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Add @extschema:name@ and no_relocate options to extensions.

  2. pkg-config Requires.private entries should be comma-separated

  3. Fix logic buglets in pg_dump's flagInhAttrs().