Re: Please provide examples of rows from

Tom Lane <tgl@sss.pgh.pa.us>

From: Tom Lane <tgl@sss.pgh.pa.us>
To: Bruce Momjian <bruce@momjian.us>
Cc: "David G. Johnston" <david.g.johnston@gmail.com>, Guyren Howe <guyren@gmail.com>, Pg Docs <pgsql-docs@lists.postgresql.org>
Date: 2020-09-24T19:05:24Z
Lists: pgsql-docs
Bruce Momjian <bruce@momjian.us> writes:
> Yes, this is very helpful.  I was afraid the JSON would overwhelm the
> example, but this looks good.  I wrote the attached doc patch which I
> think improves this.  I plan to apply it to all supported versions.

Couple thoughts:

* Taking the initial ... out of the syntax synopsis is not an improvement.
It makes it look like you can only apply AS to the first function of a
ROWS FROM.

* I think the ORDER BY adds nothing to the example except complication
and confusion.

* Maybe the other sentence of explanation would read better as

	json_to_recordset() is instructed to return two columns,
	the first integer and the second text.  The result of
	generate_series() is used directly.

			regards, tom lane



Commits

  1. Improve the error message for an inappropriate column definition list.