Re: WARNING: outfuncs/readfuncs failed to produce an equal rewritten parse tree
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Pavel Stehule <pavel.stehule@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2023-01-23T16:31:44Z
Lists: pgsql-hackers
Pavel Stehule <pavel.stehule@gmail.com> writes: > After some investigation, I found a problem in the RangeVar node. > The field "catalogname" is setted to NULL in _readRangeVar, but it is > compared in _equalRangeVar function. > I thought so it is problem in my patch, but it looks like generic issue: > create table postgres.public.foo(a int); > WARNING: outfuncs/readfuncs failed to produce an equal rewritten parse tree > CREATE TABLE Heh. Probably we should just drop that special treatment of the catalogname field --- that was always premature optimization, given that (I think) we don't ever store RangeVar in the catalogs. The alternative would be to also lobotomize comparisons of RangeVars by marking the field equal_ignore, but what's the point? regards, tom lane
Commits
-
Remove special outfuncs/readfuncs handling of RangeVar.catalogname.
- 3cece34be842 16.0 landed