Horton

Re: Augment every test postgresql.conf

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Noah Misch <noah@leadboat.com>
Cc: pgsql-hackers@postgresql.org
Date: 2018-12-30T03:46:31Z
Lists: pgsql-hackers 
Noah Misch <noah@leadboat.com> writes:
> Looking more closely, we already have the TEMP_CONFIG variable and apply it to
> everything except TAP suites.  Closing that gap, as attached, is enough.  The
> buildfarm client uses TEMP_CONFIG to implement its extra_config setting, so
> this will cause extra_config to start applying to TAP suites.

Seems reasonable, but it might be a good idea to warn the buildfarm-owners
list before committing.  (Although I guess it wouldn't be hard to check
the buildfarm database to see if anyone is putting anything interesting
into their critters' TEMP_CONFIG.)

Also, if we're to do this, it seems like applying it to back branches
would be helpful --- but will it work in all the back branches?

			regards, tom lane

Commits

  1. Fail pgwin32_message_to_UTF16() for SQL_ASCII messages.

  2. Honor TEMP_CONFIG in TAP suites.

  3. Respect TEMP_CONFIG when pg_regress_check and friends are called