Horton

Re: pgsql: Merge catalog/pg_foo_fn.h headers back into pg_foo.h headers.

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Michael Paquier <michael@paquier.xyz>
Cc: Postgres hackers <pgsql-hackers@postgresql.org>
Date: 2018-04-09T03:05:09Z
Lists: pgsql-hackers 
Michael Paquier <michael@paquier.xyz> writes:
> On Sun, Apr 08, 2018 at 06:35:39PM +0000, Tom Lane wrote:
>> Merge catalog/pg_foo_fn.h headers back into pg_foo.h headers.

> This patch or one of its relatives has visibly broken parallel builds
> for me. "make -j 4 install" directly called after a configure complains:

Hm.  I'd tested "make -j all", but not going directly to "install".
Does it help if you add

$(SUBDIRS:%=install-%-recurse): | submake-generated-headers

to src/Makefile?

(That seems like a bit of a brute-force solution, though.  Anybody
have a better answer?)

			regards, tom lane

Commits

  1. Fix pgxs.mk to not try to build generated headers in external builds.

  2. Fix partial-build problems introduced by having more generated headers.

  3. Further cleanup of client dependencies on src/include/catalog headers.

  4. Merge catalog/pg_foo_fn.h headers back into pg_foo.h headers.

  5. Switch client-side code to include catalog/pg_foo_d.h not pg_foo.h.