Re: PGOPTIONS="-fh" make check gets stuck since Postgres 11
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Thomas Munro <thomas.munro@gmail.com>
Cc: Michael Paquier <michael@paquier.xyz>,
Postgres hackers <pgsql-hackers@lists.postgresql.org>
Date: 2019-07-09T02:22:13Z
Lists: pgsql-hackers
Thomas Munro <thomas.munro@gmail.com> writes: > On Tue, Jul 9, 2019 at 2:19 AM Tom Lane <tgl@sss.pgh.pa.us> wrote: >> Given the purposes of this test, I think it'd be reasonable to force >> both enable_hashjoin = on and enable_mergejoin = off at the very top >> of the join_hash script, or the corresponding place in join.sql in >> v11. Thomas, was there a specific reason for forcing enable_mergejoin >> = off for only some of these tests? > Based on a suggestion from Andres (if I recall correctly), I wrapped > each individual test in savepoint/rollback, and then set just the GUCs > needed to get the plan shape and execution code path I wanted to > exercise, and I guess I found that I only needed to disable merge > joins for some of them. The idea was that the individual tests could > be understood independently. But per this discussion, they can only be "understood independently" if you make some assumptions about the prevailing values of the planner GUCs. regards, tom lane
Commits
-
Force hash joins to be enabled in the hash join regression tests.
- 3955c50f3762 11.5 landed
- cba0fe024e35 13.0 landed
- 5526baf54902 12.0 landed