Re: strange failure in plpgsql_control tests (on fulmar, ICC 14.0.3)
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
Cc: pgsql-hackers@lists.postgresql.org,
Tomas Vondra <tomas.vondra@2ndquadrant.com>
Date: 2018-03-17T19:25:57Z
Lists: pgsql-hackers
Andres Freund <andres@anarazel.de> writes: > I don't think performance is a prime driver here, or shouldn't be at least. Obviousness / grepability seem much more important. I'd vote for using my version in master, and yours in the back branches. I can do that, of you want. I dunno, I think the code as I had it is quite obvious. It's just that I don't really like hard-coding references to INT_MIN/MAX, which I guess is a personal style thing rather than anything I can defend well. > I'm OK with skipping the test for now. If we're not putting a test into the back branches, then we darn well better be using the same code there as in HEAD, else we won't know that it actually solves the problem. regards, tom lane
Commits
-
Fix overflow handling in plpgsql's integer FOR loops.
- f1f7a85d8c3e 9.3.23 landed
- b3fade55cba6 9.5.13 landed
- 5917297bfd25 9.6.9 landed
- 2dbee9f19f6c 11.0 landed
- 092401b14fa1 9.4.18 landed
- 04c76acab46f 10.4 landed