Re: BUG #17067: FailedAssertion at castNodeImpl
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: David Rowley <dgrowleyml@gmail.com>
Cc: cyg0810@gmail.com,
PostgreSQL mailing lists <pgsql-bugs@lists.postgresql.org>
Date: 2021-06-21T13:33:29Z
Lists: pgsql-bugs
David Rowley <dgrowleyml@gmail.com> writes: > On Mon, 21 Jun 2021 at 20:15, PG Bug reporting form > <noreply@postgresql.org> wrote: >> run the following sql command through client and the PostgreSQL database >> process will crash: > Thanks for the report. It looks like a thinko in 1d581ce71. Code > was added there which insists the initial list element is a List, but > it's an IntList. I think the code should just use linitial instead of > linitial_node. Hmm, if it's an int-list then the subsequent dup-elimination loop is also wrong, and for that matter I don't think the preceding lines would have worked. > I'm quite surprised that we don't have a test that picks this up. The code coverage report shows that we *do* have tests that run through this code, so the existing typing is okay in the test cases we have. I'm guessing the real problem is that something upstream is generating the wrong type of list in this example. regards, tom lane
Commits
-
Fix assert failure in expand_grouping_sets
- 8d29d45d9b3c 14.0 landed