Horton

Thread

Commits

  1. Constify the arguments of copydir.h functions

  1. constify arguments of copy_file() and copydir()

    Nathan Bossart <nathandbossart@gmail.com> — 2023-01-14T23:11:26Z

    I've attached a patch for $SUBJECT, which allows us to remove a use of the
unconstify macro in basic_archive.  This is just a pet peeve, but maybe it
bothers others, too.

-- 
Nathan Bossart
Amazon Web Services: https://aws.amazon.com

  2. Re: constify arguments of copy_file() and copydir()

    Andrew Dunstan <andrew@dunslane.net> — 2023-01-15T13:23:13Z

    On 2023-01-14 Sa 18:11, Nathan Bossart wrote:
> I've attached a patch for $SUBJECT, which allows us to remove a use of the
> unconstify macro in basic_archive.  This is just a pet peeve, but maybe it
> bothers others, too.


I don't like using unconstify where it can be avoided, so this looks
reasonable to me.


cheers


andrew

--
Andrew Dunstan
EDB: https://www.enterprisedb.com

  3. Re: constify arguments of copy_file() and copydir()

    Nathan Bossart <nathandbossart@gmail.com> — 2023-01-15T16:13:28Z

    On Sun, Jan 15, 2023 at 08:23:13AM -0500, Andrew Dunstan wrote:
> On 2023-01-14 Sa 18:11, Nathan Bossart wrote:
>> I've attached a patch for $SUBJECT, which allows us to remove a use of the
>> unconstify macro in basic_archive.  This is just a pet peeve, but maybe it
>> bothers others, too.
> 
> I don't like using unconstify where it can be avoided, so this looks
> reasonable to me.

Thanks.  Added to the next commitfest:

	https://commitfest.postgresql.org/42/4126/

-- 
Nathan Bossart
Amazon Web Services: https://aws.amazon.com

  4. Re: constify arguments of copy_file() and copydir()

    Michael Paquier <michael@paquier.xyz> — 2023-01-16T01:53:40Z

    On Sun, Jan 15, 2023 at 08:13:28AM -0800, Nathan Bossart wrote:
> On Sun, Jan 15, 2023 at 08:23:13AM -0500, Andrew Dunstan wrote:
>> On 2023-01-14 Sa 18:11, Nathan Bossart wrote:
>>> I've attached a patch for $SUBJECT, which allows us to remove a use of the
>>> unconstify macro in basic_archive.  This is just a pet peeve, but maybe it
>>> bothers others, too.
>> 
>> I don't like using unconstify where it can be avoided, so this looks
>> reasonable to me.

+1.
--
Michael

  5. Re: constify arguments of copy_file() and copydir()

    Michael Paquier <michael@paquier.xyz> — 2023-01-17T06:24:54Z

    On Mon, Jan 16, 2023 at 10:53:40AM +0900, Michael Paquier wrote:
> +1.

While I don't forget about this thread..  Any objections if I were to
apply that?
--
Michael

  6. Re: constify arguments of copy_file() and copydir()

    Peter Eisentraut <peter.eisentraut@enterprisedb.com> — 2023-01-17T19:23:49Z

    On 17.01.23 07:24, Michael Paquier wrote:
> On Mon, Jan 16, 2023 at 10:53:40AM +0900, Michael Paquier wrote:
>> +1.
> 
> While I don't forget about this thread..  Any objections if I were to
> apply that?

Looks good to me.

  7. Re: constify arguments of copy_file() and copydir()

    Michael Paquier <michael@paquier.xyz> — 2023-01-18T00:05:52Z

    On Tue, Jan 17, 2023 at 08:23:49PM +0100, Peter Eisentraut wrote:
> Looks good to me.

Thanks, done.
--
Michael

  8. Re: constify arguments of copy_file() and copydir()

    Nathan Bossart <nathandbossart@gmail.com> — 2023-01-18T00:08:02Z

    On Wed, Jan 18, 2023 at 09:05:52AM +0900, Michael Paquier wrote:
> Thanks, done.

Thanks!

-- 
Nathan Bossart
Amazon Web Services: https://aws.amazon.com