Re: 010_database.pl fails on openbsd w/ LC_ALL=LANG=C

Jeff Davis <pgsql@j-davis.com>

From: Jeff Davis <pgsql@j-davis.com>
To: Andres Freund <andres@anarazel.de>, pgsql-hackers@postgresql.org
Date: 2023-07-07T15:52:34Z
Lists: pgsql-hackers
On Sun, 2023-07-02 at 09:56 -0700, Andres Freund wrote:
> #     expected: anything else
> [07:25:06.424](0.001s) not ok 7 - ICU-specific locale must be
> specified with ICU_LOCALE: error message
> [07:25:06.424](0.001s) #   Failed test 'ICU-specific locale must be
> specified with ICU_LOCALE: error message'
> #   at /home/postgres/postgres/src/test/icu/t/010_database.pl line
> 80.
> [07:25:06.424](0.000s) #                   'psql:<stdin>:2: NOTICE: 
> using standard form "und-u-ks-level1" for ICU locale
> "@colStrength=primary"'
> #     doesn't match '(?^:ERROR:  invalid LC_COLLATE locale name)'
> [07:25:06.425](0.000s) 1..7

[I apologize for the delay.]

The test is assuming that locale "@colStrength=primary" is valid for
ICU but invalid for libc. It seems that on that platform, setlocale()
is accepting it?

If some libc implementations are too permissive, I might need to just
disable this test. But if we can find a locale that is consistently
acceptable in ICU but invalid in libc, then I can keep it... perhaps
"und@colStrength=primary"?

Regards,
	Jeff Davis




Commits

  1. ICU: remove negative test that fails to fail.