Shouldn't postgres_fdw report warning when it gives up getting result from foreign server?
Fujii Masao <masao.fujii@oss.nttdata.com>
From: Fujii Masao <masao.fujii@oss.nttdata.com>
To: pgsql-hackers@lists.postgresql.org
Date: 2021-11-19T10:01:26Z
Lists: pgsql-hackers
Hi, postgres_fdw reports no log message when it sends "ABORT TRANSACTION" etc and gives up getting a reply from a foreign server because of timeout or connection trouble. This makes the troubleshooting a bit harder when using postgres_fdw. So how about making postgres_fdw report a warning in that case? Specifically I'm thinking to change pgfdw_get_cleanup_result() in postgres_fdw/connection.c so that it reports a warning in case of a timeout or connection failure (error of PQconsumeInput()). BTW, pgfdw_get_cleanup_result() does almost the same things as what pgfdw_get_result() does. So it might be good idea to refactor those function to reduce the code duplication. Regards, -- Fujii Masao Advanced Computing Technology Center Research and Development Headquarters NTT DATA CORPORATION
Commits
-
postgres_fdw: Report warning when timeout expires while getting query result.
- 815d61fcd485 15.0 landed