Re: Allow default \watch interval in psql to be configured
Daniel Gustafsson <daniel@yesql.se>
From: Daniel Gustafsson <daniel@yesql.se>
To: Heikki Linnakangas <hlinnaka@iki.fi>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2024-10-09T14:24:27Z
Lists: pgsql-hackers
Attachments
- v2-0001-Make-default-watch-interval-configurable.patch (application/octet-stream) patch v2-0001
> On 9 Oct 2024, at 16:05, Heikki Linnakangas <hlinnaka@iki.fi> wrote: Thanks for looking! > I guess the '1000' was supposed to be the maximum, but ParseVariableDouble doesn't take a maximum. Doh, I had a max parameter during hacking but removed it since I didn't see a clear usecase for it. Since it's not an externally published API we can alwasys add it when there is need. Clearly I managed to generate the patch at the wrong time without noticing. Fixed. > That's a little inaccurate: 0 is also accepted, so should be "must be greater than *or equal to* 0". Or maybe "cannot be negative". -0 is also accepted, though. I changed to "must be at least XX" to keep the message short. > set -> sets > > beetween -> between Fixed. -- Daniel Gustafsson
Commits
-
psql: Fix incorrect equality comparison
- 0f3604a518f8 18.0 landed
-
psql: Make test robust against locale variations
- 1eb399366ed6 18.0 landed
-
psql: Make default \watch interval configurable
- 1a759c83278f 18.0 landed