Re: Fix overflow in DecodeInterval
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Joseph Koshakow <koshy44@gmail.com>
Cc: Andres Freund <andres@anarazel.de>,
PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2022-04-02T20:14:15Z
Lists: pgsql-hackers
Joseph Koshakow <koshy44@gmail.com> writes: > On Sat, Apr 2, 2022 at 3:08 PM Tom Lane <tgl@sss.pgh.pa.us> wrote: >> I think it's not, at least not for the interesting range of possible >> values in this code. Given that abs(frac) < 1 to start with, the >> abs value of usec can't exceed the value of scale, which is at most >> USECS_PER_DAY so it's at most 37 or so bits, which is well within >> the exact range for any sane implementation of double. It would >> take a very poor floating-point implementation to not get the right >> answer here. (And we're largely assuming IEEE-compliant floats these >> days.) > Ah, I see. That makes sense to me. Cool. I've pushed the patch. regards, tom lane
Commits
-
Fix portability issues in datetime parsing.
- 591e088dd5b3 15.0 landed
-
Fix overflow hazards in interval input and output conversions.
- e39f99046710 15.0 landed
-
Add a couple more tests for interval input decoding.
- 1b208ebaf14e 15.0 landed