Horton

Re: Make description of heap records more talkative for flags

Nathan Bossart <bossartn@amazon.com>

View thread View on postgr.es
From: Nathan Bossart <bossartn@amazon.com>
To: pgsql-hackers@lists.postgresql.org
Cc: Michael Paquier <michael@paquier.xyz>
Date: 2018-06-15T15:08:27Z
Lists: pgsql-hackers 
The following review has been posted through the commitfest application:
make installcheck-world:  not tested
Implements feature:       not tested
Spec compliant:           not tested
Documentation:            not tested

-		appendStringInfo(buf, "off %u", xlrec->offnum);
+		appendStringInfo(buf, "off %u flags %02X", xlrec->offnum,
+						 xlrec->flags);

Can we add "0x" before the flags so that it is abundantly clear it's a
hex value?

Nathan

Commits

  1. Add flag values in WAL description to all heap records

  2. Fix incorrect routine name in xlog_heapam.h