Re: New gist vacuum.
Michail Nikolaev <michail.nikolaev@gmail.com>
From: Michail Nikolaev <michail.nikolaev@gmail.com>
To: pgsql-hackers@lists.postgresql.org
Cc: Andrey Borodin <x4mmm@yandex-team.ru>
Date: 2018-02-25T13:49:02Z
Lists: pgsql-hackers
The following review has been posted through the commitfest application: make installcheck-world: tested, passed Implements feature: tested, passed Spec compliant: not tested Documentation: not tested Hello. I have added small change to patch to allow it be compiled using msvc (uint64_t -> uint64). Everything seems to work, check-world is passing. Actually patch fixes two issues: 1) Partial GIST indexes now have corrent tuples count estimation. 2) Now subsequent calls to VACUUM on GIST index (like "VACCUM table_name") do not change tuples count to estimated number of tuples in table (which is changed even without any updates in table due current implementation). I think it is fine to commit. Patch is also availble on github: https://github.com/michail-nikolaev/postgres/commit/ff5171b586e4eb60ea5d15a18055d8ea4e44d244?ts=4 I'll attach patch file next message. The new status of this patch is: Ready for Committer
Commits
-
Make gistvacuumcleanup() count the actual number of index tuples.
- ccd650430db6 10.4 landed
- 947f06c6224e 9.4.18 landed
- 81b9b5ce490a 11.0 landed
- 6b56f07525a0 9.3.23 landed
- 529137cac9a8 9.6.9 landed
- 46d98da43e56 9.5.13 landed