Horton
Menu

Re: Making type Datum be 8 bytes everywhere

Tom Lane <tgl@sss.pgh.pa.us>

View thread
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Nazir Bilal Yavuz <byavuz81@gmail.com>
Cc: Andres Freund <andres@anarazel.de>, pgsql-hackers@lists.postgresql.org, Robert Haas <robertmhaas@gmail.com>
Date: 2025-07-30T15:48:08Z
Lists: pgsql-hackers 
Nazir Bilal Yavuz <byavuz81@gmail.com> writes:
> On Wed, 23 Jul 2025 at 22:00, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> I'm disinclined to put in a huge amount of effort looking for the
>> worst case.  We established long ago that we weren't going to
>> optimize for 32-bit anymore.  So as long as this doesn't completely
>> tank performance on 32-bit, I'm satisfied.  I'd almost say that
>> if standard pgbench doesn't notice the change, that's good enough.

> I did a basic pgbench benchmark on a 32-bit build and there is no change.

Thanks for doing that!  For me, that's enough evidence to move
forward.

			regards, tom lane

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Avoid faulty alignment of Datums in build_sorted_items().

  2. Grab the low-hanging fruit from forcing USE_FLOAT8_BYVAL to true.

  3. Grab the low-hanging fruit from forcing sizeof(Datum) to 8.

  4. Make type Datum be 8 bytes wide everywhere.

  5. Mop-up for Datum conversion cleanups.