Re: Reducing pg_ctl's reaction time
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
Cc: Jeff Janes <jeff.janes@gmail.com>,
Michael Paquier <michael.paquier@gmail.com>,
PostgreSQL mailing lists <pgsql-hackers@postgresql.org>
Date: 2017-06-26T21:30:30Z
Lists: pgsql-hackers
Andres Freund <andres@anarazel.de> writes: > It'd be quite possible to address the race-condition by moving the > updating of the control file to postmaster, to the > CheckPostmasterSignal(PMSIGNAL_BEGIN_HOT_STANDBY) block. That'd require > updating the control file from postmaster, which'd be somewhat ugly. No, I don't like that at all. Has race conditions against updates coming from the startup process. > Perhaps that indicates that field shouldn't be in pg_control, but in the > pid file? Yeah, that would be a different way to go at it. The postmaster would probably just write the state of the hot_standby GUC to the file, and pg_ctl would have to infer things from there. regards, tom lane
Commits
-
Change pg_ctl to detect server-ready by watching status in postmaster.pid.
- f13ea95f9e47 10.0 landed
-
Reduce pg_ctl's reaction time when waiting for postmaster start/stop.
- c61559ec3a41 10.0 landed