Re: PostgreSQL crashes with SIGSEGV

Aleksandr Parfenov <a.parfenov@postgrespro.ru>

From: Aleksandr Parfenov <a.parfenov@postgrespro.ru>

To: pgsql-hackers@lists.postgresql.org

Cc: Peter Geoghegan <pg@bowt.ie>

Date: 2018-01-16T07:52:26Z

Lists: pgsql-bugs, pgsql-hackers

The following review has been posted through the commitfest application:
make installcheck-world:  tested, passed
Implements feature:       tested, passed
Spec compliant:           tested, passed
Documentation:            tested, passed

Hi,

All information is related to WIP-tuplesort-memcontext-fix.patch.
The patch applies and fixes the bug on REL9_6_STABLE and LGTM.

However, REL9_5_STABLE affected as well and the patch doesn't applicable to it.
But it may be another entry because the difference in tuplesort may cause some changes in the fix too.

The new status of this patch is: Ready for Committer

Commits

Fix actual and potential double-frees around tuplesort usage.
- c2d4eb1b1fa2 11.0 landed
- e4ff711582b1 9.5.13 landed
- c98f218fbf5a 10.4 landed
- 90decdba3786 9.6.9 landed
Allow the built-in ordered-set aggregates to share transition state.
- be0ebb65f512 11.0 cited
Avoid integer overflow while sifting-up a heap in tuplesort.c.
- 512f67c8d02c 10.0 cited
Allow avoiding tuple copy within tuplesort_gettupleslot().
- fa117ee40330 10.0 cited
Remove should_free arguments to tuplesort routines.
- 3856cf9607f4 10.0 cited
Fix use-after-free around DISTINCT transition function calls.
- a5f0bd77a2fa 9.6.1 cited
- d8589946ddd5 10.0 cited
Reuse abbreviated keys in ordered [set] aggregates.
- f1f5ec1efafe 9.6.0 cited