Re: Fwd: pg_trgm word_similarity inconsistencies or bug

Jan Przemysław Wójcik <jan.przemyslaw.wojcik@gmail.com>

From: Jan Przemysław Wójcik <jan.przemyslaw.wojcik@gmail.com>
To: pgsql-bugs@postgresql.org
Date: 2017-11-07T12:51:35Z
Lists: pgsql-bugs, pgsql-hackers
Hi,

my statement about the function usefulness was probably too categorical,
though I had in mind the current name of the function. 

I'm afraid that creating a function that implements quite different
algorithms depending on a global parameter seems very hacky and would lead
to misunderstandings. I do understand the need of backward compatibility,
but I'd opt for the lesser evil. Perhaps a good idea would be to change the
name to 'substring_similarity()' and introduce the new function
'word_similarity()' later, for example in the next major version release.

------
Jan Przemysław Wójcik 



--
Sent from: http://www.postgresql-archive.org/PostgreSQL-bugs-f2117394.html


Commits

  1. Update trigram example in docs to correct state

  2. Add strict_word_similarity to pg_trgm module

  3. Rework word_similarity documentation, make it close to actual algorithm.