Re: Sigh, I broke crake again
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
Cc: Andrew Dunstan <andrew@dunslane.net>, pgsql-hackers@lists.postgresql.org
Date: 2018-02-27T19:38:52Z
Lists: pgsql-hackers
I wrote: > I had not intended to back-patch, since those changes were just cosmetic, > but it might be the best way to preserve the XversionUpgrade tests. After closer study, it seems like the least painful answer is: 1. In HEAD, revert the renaming of int44in/int44out to city_budget_in/_out; the gain in obviousness isn't worth the screwing around we'd have to do to cope with it in cross-version upgrade testing. 2. In the back branches, drop the CREATE FUNCTION commands for funny_dup17 and boxarea, which are used nowhere so they can easily be dispensed with. We could ask TestUpgradeXversion.pm to drop the latter two functions, similarly to what it's already doing for oldstyle_length. But oldstyle_length was actually being used for something in the older branches so it was worth the trouble to cope with a cross-branch difference. These two don't seem worth changing the buildfarm for. regards, tom lane
Commits
-
Revert renaming of int44in/int44out.
- c40e20a83ce5 11.0 landed
-
Remove regression tests' CREATE FUNCTION commands for unused C functions.
- 0c4af129941b 9.3.23 landed
- 5cedaeca261b 9.4.18 landed
- 85be69154a1e 9.5.13 landed
- df3962c00b36 9.6.9 landed
- d6ff2e30395b 10.4 landed