Horton
Menu

Re: pg_plan_advice

Tom Lane <tgl@sss.pgh.pa.us>

View thread
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Matheus Alcantara <matheusssilv97@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2026-03-19T22:03:14Z
Lists: pgsql-hackers 
Robert Haas <robertmhaas@gmail.com> writes:
> .... Or maybe the recent
> "timedout" errors in the buildfarm are a sign that 1000s isn't long
> enough for this more-intensive run:

> https://buildfarm.postgresql.org/cgi-bin/show_failures.pl?max_days=3&stage=timedout&filter=Submit

I think those are all mostly-unrelated.  icarus has never yet been
stable enough to complete a BF run, and morepork and schnauzer's
wait_timeout parameters were set to 7200 (2 hours) which the test run
had organically grown to exceed.  Maybe test_plan_advice helped push
them over the edge, but they were going to need a larger setting
sometime soon anyway.  (And I see Mikael's fixed that.)

> If so, that would be sad. On my local machine, which is a ~3 yo
> MacBook, running just the "regress" test suite takes ~11.1 s, and
> running just the "test_plan_advice" suite takes ~12s, so I admit that
> I'm slightly confused about why this is having such a big impact for
> you and Tom.

Please note that I was citing the runtime of a much slower machine
(longfin is a 2018 mac mini).  But in any case, what I was griping
about was the additional cost added to a buildfarm run; I don't see
that test_plan_advice is a lot slower than the main regression tests.
It's just that those are already a significant investment, and we
just iterated them another time.

			regards, tom lane

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. pg_plan_advice: Fix another unique-semijoin bug.

  2. pg_plan_advice: Export feedback-related definitions.

  3. pg_plan_advice: Fix a bug when a subquery is pruned away entirely.

  4. pg_plan_advice: Add alternatives test to Makefile.

  5. pg_plan_advice: Handle non-repeatable TABLESAMPLE scans.

  6. pg_stash_advice: Allow stashed advice to be persisted to disk.

  7. Add pg_stash_advice contrib module.

  8. pg_plan_advice: Avoid assertion failure with partitionwise aggregate.

  9. pg_plan_advice: Invent DO_NOT_SCAN(relation_identifier).

  10. Add an alternative_plan_name field to PlannerInfo.

  11. pg_plan_advice: Refactor to invent pgpa_planner_info

  12. Respect disabled_nodes in fix_alternative_subplan.

  13. get_memoize_path: Don't exit quickly when PGS_NESTLOOP_PLAIN is unset.

  14. test_plan_advice: Set TAP test priority 50 in meson.build.

  15. pg_plan_advice: Avoid a crash under GEQO.

  16. Test pg_plan_advice using a new test_plan_advice module.

  17. pg_plan_advice: Always install pg_plan_advice.h, and in the right place

  18. pg_plan_advice: Fix failures to accept identifier keywords.

  19. Add pg_plan_advice contrib module.

  20. Allow extensions to mark an individual index as disabled.

  21. Replace get_relation_info_hook with build_simple_rel_hook.

  22. Store information about Append node consolidation in the final plan.

  23. Store information about elided nodes in the final plan.

  24. Store information about range-table flattening in the final plan.

  25. Pass cursorOptions to planner_setup_hook.

  26. Fix PGS_CONSIDER_NONPARTIAL interaction with Materialize nodes.

  27. Fix mistakes in commit 4020b370f214315b8c10430301898ac21658143f

  28. Allow for plugin control over path generation strategies.

  29. Update some comments for fasthash

  30. Allow passing a pointer to GetNamedDSMSegment()'s init callback.

  31. Don't reset the pathlist of partitioned joinrels.

  32. Treat number of disabled nodes in a path as a separate cost metric.