Re: Switching timeline over streaming replication

Tom Lane <tgl@sss.pgh.pa.us>

From: Tom Lane <tgl@sss.pgh.pa.us>
To: Heikki Linnakangas <hlinnakangas@vmware.com>
Cc: Amit Kapila <amit.kapila@huawei.com>, "'PostgreSQL-development'" <pgsql-hackers@postgresql.org>
Date: 2012-11-15T14:55:26Z
Lists: pgsql-hackers
Heikki Linnakangas <hlinnakangas@vmware.com> writes:
> This is a fairly general issue, actually. Looking around, I can see at 
> least two similar cases in existing code, with BasicOpenFile, where we 
> will leak file descriptors on error:

Um, don't we automatically clean those up during transaction abort?
If we don't, we ought to think about that, not about cluttering calling
code with certain-to-be-inadequate cleanup in error cases.

			regards, tom lane