Horton
Menu

Re: [PATCH] Compressed TOAST data corruption with REPACK CONCURRENTLY

Antonin Houska <ah@cybertec.at>

View thread
From: Antonin Houska <ah@cybertec.at>
To: alvherre@kurilemu.de
Cc: "Michael Paquier" <michael@paquier.xyz>, "SATYANARAYANA NARLAPURAM" <satyanarlapuram@gmail.com>, "L. pgsql-hackers" <pgsql-hackers@lists.postgresql.org>
Date: 2026-04-25T17:33:38Z
Lists: pgsql-hackers 
Álvaro Herrera <alvherre@kurilemu.de> wrote:

> > ok, this is a patch to enhance the tests. It also simplifies
> > gen_compressible() a bit and adjusts it so it is (hopefully) more reliable in
> > generating compressible values. Now it can be used to reproduce the fix [1].
> >
> > [1] https://www.postgresql.org/message-id/52301.1776440752%40localhost
> 
> Thanks, I think it looks good, but unfortunately I don't see any problems
> when running this test without your fix (I was assuming that the test would
> fail). I didn't immediately understand why.  Do you see any failures?

The enhanced tests should reproduce it (please let me know if they dont):

https://www.postgresql.org/message-id/44015.1776685220%40localhost

-- 
Antonin Houska
Web: https://www.cybertec-postgresql.com

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. REPACK CONCURRENTLY: fix processing of toasted tuples