Horton
Menu

Re: PGXS: REGRESS_OPTS=--load-language=plpgsql

David E. Wheeler <david@kineticode.com>

View thread
From: "David E. Wheeler" <david@kineticode.com>
To: Bruce Momjian <bruce@momjian.us>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Dimitri Fontaine <dfontaine@hi-media.com>, Robert Haas <robertmhaas@gmail.com>, Takahiro Itagaki <itagaki.takahiro@oss.ntt.co.jp>, David Fetter <david@fetter.org>, Euler Taveira de Oliveira <euler@timbira.com>, PG Hackers <pgsql-hackers@postgresql.org>
Date: 2010-02-20T19:25:56Z
Lists: pgsql-hackers 
On Feb 20, 2010, at 11:03 AM, Bruce Momjian wrote:

>> There is also the "must fix" issue with pg_regress.
> 
> Why?  My pg_regress runs just fine.  If you are talking about 3rd party
> modules, I suggested conditional Makefile rules.

Because you can either make the simple change to pg_regress that David Fetter sent yesterday and have things continue to work, or you can break a slew of third-party module test suites (and possibly modules, as well) and make a lot of other people do a lot more work, not to mention email -hackers and ask WTF happened because they may well not know.

I think that not changing pg_regress is more work for third-party module maintainers *and* more work for the Pg community when those maintainers come asking what happened and for advice on how to fix it.

Best,

David