Horton

Re: [Patch] Optimize dropping of relation buffers using dlist

Konstantin Knizhnik <knizhnik@garret.ru>

View thread View on postgr.es
From: Konstantin Knizhnik <knizhnik@garret.ru>
To: pgsql-hackers@lists.postgresql.org
Cc: Kirk Jamison <k.jamison@fujitsu.com>
Date: 2020-07-30T17:37:10Z
Lists: pgsql-hackers 
The following review has been posted through the commitfest application:
make installcheck-world:  tested, passed
Implements feature:       tested, passed
Spec compliant:           not tested
Documentation:            not tested

I have tested this patch at various workloads and hardware (including Power2 server with 384 virtual cores)
and didn't find performance regression.

The new status of this patch is: Ready for Committer

Commits

  1. Fix size overflow in calculation introduced by commits d6ad34f3 and bea449c6.

  2. Optimize DropRelFileNodesAllBuffers() for recovery.

  3. Optimize DropRelFileNodeBuffers() for recovery.

  4. Cache smgrnblocks() results in recovery.

  5. Add a check to prevent overwriting valid data if smgrnblocks() gives a