Re: Attempt to consolidate reading of XLOG page

Antonin Houska <ah@cybertec.at>

View thread View on postgr.es

From: Antonin Houska <ah@cybertec.at>

To: Robert Haas <robertmhaas@gmail.com>

Cc: Alvaro Herrera <alvherre@2ndquadrant.com>, "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>

Date: 2019-05-21T09:11:37Z

Lists: pgsql-hackers

Attachments

v03_001_Unexport_XLogReaderInvalReadState.patch (text/x-diff) patch v3
v03_002_Remove_TLI_argument_from_XLR_callback.patch (text/x-diff) patch v3
v03_003_Introduce_XLogSegment.patch (text/x-diff) patch v3
v03_004_Use_only_one_implementation_of_XLogRead.patch (text/x-diff) patch v3
v03_005_Cleanup.patch (text/x-diff) patch v3

Robert Haas <robertmhaas@gmail.com> wrote:
> It seems to me that it's better to unwind the stack i.e. have the
> function return the error information to the caller and let the caller
> do as it likes.

Thanks for a hint. The next version tries to do that.

-- 
Antonin Houska
Web: https://www.cybertec-postgresql.com

Commits

Remove logical_read_local_xlog_page
- 5d0c2d5eba6b 13.0 landed
Refactor WAL file-reading code into WALRead()
- 0dc8ead46363 13.0 landed
Rework WAL-reading supporting structs
- 709d003fbd98 13.0 landed
Make XLogReaderInvalReadState static
- 25dcc9d35dfe 13.0 landed
Use pg_pread() and pg_pwrite() for data files and WAL.
- c24dcd0cfd94 12.0 cited