Re: Tightening up allowed custom GUC names

Tom Lane <tgl@sss.pgh.pa.us>

From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andrew Dunstan <andrew@dunslane.net>
Cc: Noah Misch <noah@leadboat.com>, pgsql-hackers@lists.postgresql.org
Date: 2021-04-07T15:23:34Z
Lists: pgsql-hackers
I wrote:
> We can't allow '-', for the specific reason that it won't work as a -c
> argument (thanks to -c's translation of '-' to '_').  The whole point here
> is to prevent corner cases like that.  ':' would be all right, but I think
> it's a lot simpler to explain and a lot harder to break in future if we
> just say that the names have to be valid identifiers.

Hearing no further comments, I pushed the more restrictive version.

			regards, tom lane



Commits

  1. Tighten up allowed names for custom GUC parameters.