Re: Fix memleaks and error handling in jsonb_plpython

Tom Lane <tgl@sss.pgh.pa.us>

From: Tom Lane <tgl@sss.pgh.pa.us>
To: Michael Paquier <michael@paquier.xyz>
Cc: Nikita Glukhov <n.gluhov@postgrespro.ru>, PostgreSQL mailing lists <pgsql-hackers@postgresql.org>
Date: 2019-04-06T21:56:24Z
Lists: pgsql-hackers
Michael Paquier <michael@paquier.xyz> writes:
> On Wed, Mar 06, 2019 at 11:04:23AM +0900, Michael Paquier wrote:
>> Another thing is that you cannot just return within a try block with
>> what is added in PLyObject_FromJsonbContainer, or the error stack is
>> not reset properly.  So they should be replaced by breaks.

> So, I have been poking at this stuff, and I am finishing with the
> attached.

This patch had bit-rotted due to somebody else fooling with the
volatile-qualifiers situation.  I fixed it up, tweaked a couple of
things, and pushed it.

> Also, as all those
> problems are really unlikely going to happen in real-life cases,
> improving this code only on HEAD looks enough to me.

Yeah, I concur.

			regards, tom lane



Commits

  1. Avoid Python memory leaks in hstore_plpython and jsonb_plpython.