Re: Doc patch to note which system catalogs have oids

Tom Lane <tgl@sss.pgh.pa.us>

From: Tom Lane <tgl@sss.pgh.pa.us>
To: "Karl O. Pinc" <kop@meme.com>
Cc: pgsql-hackers@postgresql.org
Date: 2012-09-24T03:14:33Z
Lists: pgsql-hackers
"Karl O. Pinc" <kop@meme.com> writes:
> The attached patch documents the oid column of those
> system catalogs having an oid.

I think this is fundamentally wrong, or at least misleading, because it
documents OID as if it were an ordinary column.  Somebody who did
"select * from pg_class" and didn't see any "oid" in the result would
think the docs were wrong.

It's possible that it's worth expending a boilerplate paragraph in each
of those pages to say "this catalog has OIDs" (or that it doesn't).
But this isn't the way.

			regards, tom lane