Re: ALTER TEXT SEARCH DICTIONARY tab completion

gkokolatos@pm.me

From: Georgios Kokolatos <gkokolatos@pm.me>
To: pgsql-hackers@lists.postgresql.org
Cc: Jeff Janes <jeff.janes@gmail.com>
Date: 2020-03-04T15:02:58Z
Lists: pgsql-hackers
The following review has been posted through the commitfest application:
make installcheck-world:  not tested
Implements feature:       not tested
Spec compliant:           not tested
Documentation:            not tested

It looks good and does what it says on the tin.

One minor nitpick I feel I should add is that for completeness and
balance the equivalent `CREATE TEXT SEARCH DICTIONARY` should 
get the same treatment.

Maybe something along the lines of:
-       else if (Matches("CREATE", "TEXT", "SEARCH", "CONFIGURATION", MatchAny))
+       else if (Matches("CREATE", "TEXT", "SEARCH", "DICTIONARY|CONFIGURATION", MatchAny))

Commits

  1. Tab completion: offer parens as appropriate in CREATE/ALTER TEXT SEARCH.