Re[4]: bool_plperl transform
Ivan Panchenko <wao@mail.ru>
From: Ivan Panchenko <wao@mail.ru>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Andrew Dunstan <andrew@dunslane.net>, pgsql-hackers@lists.postgresql.org
Date: 2020-03-02T00:01:40Z
Lists: pgsql-hackers
Attachments
- bool_plperl_transform_v3.patch (application/octet-stream) patch v3
Thanks, Tom. I think now it should build, please find the fixed patch attached. I had no possibility to check it on Windows now, but the relevant changes in Mkvcbuild.pm are done, so I hope it should work. The documentation changes are also included in the same patch. Regards, Ivan >Понедельник, 2 марта 2020, 0:14 +03:00 от Tom Lane <tgl@sss.pgh.pa.us>: > >=?UTF-8?B?V2Fv?= < wao@mail.ru > writes: >> Please find the full patch attached. >The cfbot shows this failing to build on Windows: > >https://ci.appveyor.com/project/postgresql-cfbot/postgresql/build/1.0.81889 > >I believe that's a build without plperl, so what it's probably telling >you is that Mkvcbuild.pm needs to be taught to build this module >conditionally, as it already does for hstore_plperl and jsonb_plperl. > >Also, while the Linux build is passing, I can't find that it is actually >compiling or testing bool_plperl anywhere: > >https://travis-ci.org/postgresql-cfbot/postgresql/builds/656909114 > >This is likely because you didn't add it to contrib/Makefile. > >In general, I'd suggest grepping for references to hstore_plperl >or jsonb_plperl, and making sure that bool_plperl gets added where >appropriate. > >I rather imagine you need a .gitignore file, as well. > >You're also going to have to provide some documentation, because >I don't see any in the patch. > >regards, tom lane
Commits
-
Create contrib/bool_plperl to provide a bool transform for PL/Perl[U].
- 36058a3c55d2 13.0 landed