Horton

Re: \dP and \dX use ::regclass without "pg_catalog."

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Álvaro Herrera <alvherre@alvh.no-ip.org>
Cc: Michael Paquier <michael@paquier.xyz>, Justin Pryzby <pryzby@telsasoft.com>, Tatsuro Yamada <tatsuro.yamada.tf@nttcom.co.jp>, Magnus Hagander <magnus@hagander.net>, pgsql-hackers@lists.postgresql.org, Tomas Vondra <tomas.vondra@enterprisedb.com>, pgsql-hackers@postgresql.org
Date: 2022-01-08T20:03:39Z
Lists: pgsql-hackers 
=?utf-8?Q?=C3=81lvaro?= Herrera <alvherre@alvh.no-ip.org> writes:
> My point is that it's good to have it, but it would be much better to
> have something bulletproof, which we could use in an automated check
> somewhere (next to stuff like perlcritic, perhaps).  I don't know what,
> though.

Meh ... this is mostly cosmetic these days, so I can't get excited
about putting a lot of work into it.  We disclaimed search path
bulletproofness for all these queries a long time ago.

I don't object to fixing it in the name of consistency, but that's
not a reason to invest large effort.

			regards, tom lane

Commits

  1. Fix issues with describe queries of extended statistics in psql

  2. Properly schema-prefix reference to pg_catalog.pg_get_statisticsobjdef_columns

  3. psql \dX: reference regclass with "pg_catalog." prefix