Horton

Re: pg_restore crash when there is a failure before all child process is created

Ahsan Hadi <ahsan.hadi@gmail.com>

View thread View on postgr.es
From: ahsan hadi <ahsan.hadi@gmail.com>
To: pgsql-hackers@lists.postgresql.org
Cc: vignesh C <vignesh21@gmail.com>
Date: 2020-01-31T12:54:33Z
Lists: pgsql-hackers 
The following review has been posted through the commitfest application:
make installcheck-world:  tested, passed
Implements feature:       not tested
Spec compliant:           tested, passed
Documentation:            not tested

I have applied tested both patches separately and ran regression with both. No new test cases are failing with both patches.

The issues is fixed by both patches however the fix from Tom (0001-fix-worker-status.patch) looks more elegant. I haven't done a detailed code review.

Commits

  1. Fix parallel pg_dump/pg_restore for failure to create worker processes.