Horton

Re: Issues with PAM : log that it failed, whether it actually failed or not

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: La Cancellera Yoann <lacancellera.yoann@gmail.com>
Cc: pgsql-general@postgresql.org
Date: 2019-10-11T14:08:37Z
Lists: pgsql-hackers, pgsql-general 
La Cancellera Yoann <lacancellera.yoann@gmail.com> writes:
> I am having issues with PAM auth :
> it works, password are correctly checked, unknown users cannot access,
> known user can, everything looks good
> But, it always log an error by default even if auth is succesful:
> And if auth is unsuccessful, it will log that very same message twice

Those aren't errors, they're just log events.

If you're using psql to connect, the extra messages aren't surprising,
because psql will first try to connect without a password, and only
if it gets a failure that indicates that a password is needed will
it prompt the user for a password (so two connection attempts occur,
even if the second one is successful).  You can override that default
behavior with the -W switch, and I bet that will make the extra
log messages go away.

Having said that, using LOG level for unsurprising auth failures
seems excessively chatty.  More-commonly-used auth methods aren't
that noisy.

			regards, tom lane

Commits

  1. Tweak some authentication debug messages to follow project style.

  2. Avoid logging complaints about abandoned connections when using PAM.